Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: community/php7: upgrade to 7.3.6 #5863

Closed
wants to merge 1 commit into from
Closed

WIP: community/php7: upgrade to 7.3.6 #5863

wants to merge 1 commit into from

Conversation

@andypost andypost added S-hold Must not be merged now for some reason A-upgrade Upgrades an abuild labels Dec 19, 2018
@andypost
Copy link
Contributor

andypost commented Dec 19, 2018

This will make sense after 3.9 - some packages depends on php and can't work with 7.3

The goal for 3.9 release is #5569

@andypost
Copy link
Contributor

Another 7.3 extensions checked:

  • php7-pecl-apcu
  • php7-pecl-msgpack
  • php7-pecl-lzf

community/php7/APKBUILD Outdated Show resolved Hide resolved
@bratkartoffel
Copy link
Contributor Author

bratkartoffel commented Dec 24, 2018

php7-pecl-amqp: Does not compile: php-amqp/php-amqp#337
php7-pecl-apcu: Needs patch
php7-pecl-ast: OK
php7-pecl-couchbase: OK
php7-pecl-event: OK
php7-pecl-gmagick: OK
php7-pecl-igbinary: OK
php7-pecl-imagick: Needs patch
php7-pecl-lzf: OK
php7-pecl-mailparse: Does not compile: https://bugs.php.net/bug.php?id=77045
php7-pecl-mcrypt: OK
php7-pecl-memcached: Needs update
php7-pecl-mongodb: Needs patch
php7-pecl-msgpack: OK
php7-pecl-oauth: Needs patch
php7-pecl-redis: OK
php7-pecl-ssh2: Does not compile: https://bugs.php.net/bug.php?id=77265
php7-pecl-timezonedb: OK
php7-pecl-xdebug: Needs update
php7-pecl-yaml: OK
php7-pecl-zmq: Does not compile: zeromq/php-zmq#193

@andypost
Copy link
Contributor

php7-pecl-xdebug https://bugs.xdebug.org/view.php?id=1583

@andypost andypost changed the title community/php7: Update php to 7.3.0 WIP: community/php7: Update php to 7.3.0 Mar 3, 2019
@andypost
Copy link
Contributor

One more app 7.3 compatible #6684

@andypost
Copy link
Contributor

Package php7-pear-auth_sasl could be removed as outdated https://pear.php.net/package/Auth_SASL @rnalrd

@andypost
Copy link
Contributor

community/php7-pear-net_socket is not compatible with 7.3 #6708

@andypost
Copy link
Contributor

community/php7-pear-mail_mime also need testing #6710

@bratkartoffel bratkartoffel changed the title WIP: community/php7: Update php to 7.3.0 WIP: community/php7: Update php to 7.3.3 Mar 22, 2019
@andypost
Copy link
Contributor

php-ssh2 should be ready for php 7.3 #6226

@TBK
Copy link
Contributor

TBK commented Apr 11, 2019

Would be great if this could be merged before 3.10.

@TBK
Copy link
Contributor

TBK commented Apr 11, 2019

btw 7.3.4 is out https://secure.php.net/ChangeLog-7.php#7.3.4

@tcely tcely added A-upgrade-rebuild Major upgrade which requires rebuilds of other packages R-community Community repository S-needs-review Needs thorough review, should not be merged before that S-waiting-maintainer-review Waiting for the package maintainer to review a change labels May 5, 2019
@tcely tcely changed the title WIP: community/php7: Update php to 7.3.4 WIP: community/php7: upgrade to 7.3.4 May 5, 2019
@TBK
Copy link
Contributor

TBK commented May 23, 2019

7.3.5 is out https://secure.php.net/ChangeLog-7.php#7.3.5

CI status: aarch64 fails because it hits timecap (1 hour).

@bratkartoffel
Copy link
Contributor Author

@TBK Upgraded to 7.3.5 and rebased, thanks

@TBK
Copy link
Contributor

TBK commented May 24, 2019

Do we want all the static libs? https://pkgs.alpinelinux.org/contents?file=*.a&path=&name=php7-dev&branch=edge&arch=x86_64

If then I suggest we add a $pkgname-static subpkg.

@TBK
Copy link
Contributor

TBK commented May 26, 2019

Did not know of PR #7809 before writing my last comment.

@TBK
Copy link
Contributor

TBK commented May 31, 2019

@bratkartoffel bratkartoffel changed the title WIP: community/php7: upgrade to 7.3.4 WIP: community/php7: upgrade to 7.3.6 Jun 2, 2019
@Ikke
Copy link
Contributor

Ikke commented Jun 13, 2019

@bratkartoffel Is this still WIP?

@andypost
Copy link
Contributor

@Ikke yes, waiting for 3.10 release

@captn3m0
Copy link

Ignore if I'm misunderstanding this, but does this mean Alpine 3.10 will ship with PHP 7.2?

7.2 Active Support is ending in December this year and 7.2 Security Support will run out before even 3.9 (by a few months). Keeping 7.2 in 3.10 will make this way worse.

@bratkartoffel
Copy link
Contributor Author

Currently this PR is waiting on #5902 and #5905 to get merged. My tests so far are successfull, so I think that we can merge this into 3.10 soon.

@Ikke
Copy link
Contributor

Ikke commented Jun 14, 2019

@bratkartoffel 3.10 will be branched any moment now (when 3.10 is released). At that point, it's not trivial anymore to get it into 3.10.

So I'll look at those PRs today to see if they can get get merged.

@Ikke Ikke added P-high High priority S-waiting-for-dependencies One or more dependencies are required but not part of the same pull request and removed S-WIP Work in progress, don’t merge yet S-waiting-maintainer-review Waiting for the package maintainer to review a change labels Jun 14, 2019
@ncopa
Copy link
Contributor

ncopa commented Jun 14, 2019

I think we may need have pcre2-dev in depends_dev. I suggest this:

diff --git a/community/php7/APKBUILD b/community/php7/APKBUILD
index d11de41064..6de1f32eb8 100644
--- a/community/php7/APKBUILD
+++ b/community/php7/APKBUILD
@@ -37,7 +37,7 @@ url="https://secure.php.net"
 arch="all"
 license="PHP-3.01 BSD LGPL-2.0-or-later MIT Zend-2.0"
 depends="$pkgname-common"
-depends_dev="$pkgname=$pkgver-r$pkgrel autoconf pcre-dev"
+depends_dev="$pkgname=$pkgver-r$pkgrel autoconf pcre2-dev"
 # Most dependencies between extensions is auto-discovered (see _extension()).
 _depends_mysqlnd="$pkgname-openssl"
 _depends_pdo_mysql="$pkgname-pdo $pkgname-mysqlnd"
@@ -46,7 +46,7 @@ _depends_phar="$pkgname"
 # load index based on number of dependencies.
 _depends_mysqli="$pkgname-mysqlnd $pkgname-openssl"
 makedepends="
-       autoconf
+       $depends_dev
        apache2-dev
        aspell-dev
        bison
@@ -75,7 +75,6 @@ makedepends="
        libzip-dev
        net-snmp-dev
        openldap-dev
-       pcre2-dev
        postgresql-dev
        re2c
        recode-dev

@bratkartoffel
Copy link
Contributor Author

outdated / merged with fda7e51

@bratkartoffel bratkartoffel deleted the community/php7_7.3.0 branch June 14, 2019 11:59
@andypost
Copy link
Contributor

Sadly it was commited before 3.10 and will need a lot of rebuilding dependent packages

@tcely tcely removed the P-high High priority label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-upgrade Upgrades an abuild A-upgrade-rebuild Major upgrade which requires rebuilds of other packages R-community Community repository S-needs-review Needs thorough review, should not be merged before that S-waiting-for-dependencies One or more dependencies are required but not part of the same pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants